barrettruth/forge.nvim
1
1
Fork 0
Code Issues 4 Pull requests Releases 5 Packages Activity Actions

Extract compose submit side effects #772

Closed
barrettruth wants to merge 1 commit from refactor/compose-submit-side-effects-756 into main
pull from: refactor/compose-submit-side-effects-756
merge into: barrettruth:main
Conversation 0 Commits 1 Files changed 2 +276 -266
barrettruth commented 2026-05-14 04:35:50 +00:00
Owner
Copy link

Summary:

  • move compose submit side effects into a dedicated submit effects module
  • keep compose init focused on session/document orchestration
  • preserve create/edit issue and PR submit payloads, callbacks, and user messages

Verification:

  • nix develop .#ci --command just test spec/submission_integration_spec.lua spec/compose_pr_create_spec.lua spec/compose_pr_edit_spec.lua spec/compose_issue_spec.lua spec/compose_abandon_spec.lua spec/compose_split_spec.lua
  • nix develop .#ci --command just ci

Closes #756

Summary: - move compose submit side effects into a dedicated submit effects module - keep compose init focused on session/document orchestration - preserve create/edit issue and PR submit payloads, callbacks, and user messages Verification: - nix develop .#ci --command just test spec/submission_integration_spec.lua spec/compose_pr_create_spec.lua spec/compose_pr_edit_spec.lua spec/compose_issue_spec.lua spec/compose_abandon_spec.lua spec/compose_split_spec.lua - nix develop .#ci --command just ci Closes #756
Extract compose submit side effects
All checks were successful
quality / Format (pull_request) Successful in 13s
Details
quality / Lint (pull_request) Successful in 15s
Details
quality / Test (pull_request) Successful in 14s
Details
c7c011c0ce
barrettruth closed this pull request 2026-05-14 04:35:56 +00:00
All checks were successful
quality / Format (pull_request) Successful in 13s
Required
Details
quality / Lint (pull_request) Successful in 15s
Required
Details
quality / Test (pull_request) Successful in 14s
Required
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug
Something isn't working

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
fugitive

   
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
question
Further information is requested

  
v0.1.0

   
v0.2.0

   
wontfix
This will not be worked on

No labels
bug
documentation
duplicate
enhancement
fugitive
good first issue
help wanted
invalid
question
v0.1.0
v0.2.0
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
barrettruth/forge.nvim!772
No description provided.