refactor: collapse static keymap provider #335

Merged

barrettruth merged 1 commit from cleanup/keymap-static-312 into main

2026-05-11 19:53:53 +00:00

barrettruth commented

2026-05-11 19:51:47 +00:00

Owner

Problem

keymap customization was removed, but a React context still exposed fixed keymap definitions.

Solution

replace keymap context consumers with static helpers from src/lib/keymap-defs.ts
remove the now-stateless keymap context/provider
keep NavigationWrapper focused on providers that still own runtime state

Verification

nix develop --command pnpm vitest run tests/lib/keymap-defs.test.ts tests/lib/app-sidebar.test.ts --reporter=verbose
nix develop --command just lint

Closes #312

Problem - keymap customization was removed, but a React context still exposed fixed keymap definitions. Solution - replace keymap context consumers with static helpers from src/lib/keymap-defs.ts - remove the now-stateless keymap context/provider - keep NavigationWrapper focused on providers that still own runtime state Verification - nix develop --command pnpm vitest run tests/lib/keymap-defs.test.ts tests/lib/app-sidebar.test.ts --reporter=verbose - nix develop --command just lint Closes #312

barrettruth added 1 commit

2026-05-11 19:51:48 +00:00

refactor: collapse static keymap provider

quality / Test (pull_request) Successful in 15s

Details

quality / Lint (pull_request) Successful in 21s

Details

quality / Build (pull_request) Successful in 43s

Details

29b2784e52