cleanup: collapse static keymap provider after customization removal #312

New issue

Closed

opened 2026-05-11 19:19:09 +00:00 by barrettruth · 0 comments

barrettruth commented

2026-05-11 19:19:09 +00:00

Owner

Parent: #305

Problem

Keymap customization is gone, but the app still carries a context provider that returns fixed defaults. Consumers call useKeymaps() even though the definitions now live statically in src/lib/keymap-defs.ts.

Solution

Simplify keymap lookup to static helpers:

replace useKeymaps() consumers with direct helper calls where possible
remove src/contexts/keymaps.tsx if it no longer owns state
simplify NavigationWrapper/provider ownership after the keymap provider disappears
keep the help/key display behavior intact

Acceptance criteria

No React context exists solely to expose static keymap definitions.
Global/sidebar/calendar keyboard behavior is unchanged.
Keymap help tests still pass or are replaced with simpler static-helper tests.
just lint passes.

Parent: #305 ## Problem Keymap customization is gone, but the app still carries a context provider that returns fixed defaults. Consumers call `useKeymaps()` even though the definitions now live statically in `src/lib/keymap-defs.ts`. ## Solution Simplify keymap lookup to static helpers: - replace `useKeymaps()` consumers with direct helper calls where possible - remove `src/contexts/keymaps.tsx` if it no longer owns state - simplify `NavigationWrapper`/provider ownership after the keymap provider disappears - keep the help/key display behavior intact ## Acceptance criteria - No React context exists solely to expose static keymap definitions. - Global/sidebar/calendar keyboard behavior is unchanged. - Keymap help tests still pass or are replaced with simpler static-helper tests. - `just lint` passes.

barrettruth added this to the v0.1.0 milestone

2026-05-11 19:19:09 +00:00

barrettruth added the

track:core

track:ui

type:cleanup

labels

2026-05-11 19:19:09 +00:00

barrettruth referenced this issue

2026-05-11 19:20:49 +00:00

tracker: blank-start cleanup and foundation migration #305

barrettruth referenced this issue from a pull request that will close it,