barrettruth/nix
1
0
Fork 0
Code Issues Pull requests Releases Packages Activity Actions

PR diffs 3: generalize diff source discovery for PR and compare surfaces #26

New issue
Closed
opened 2026-05-09 03:28:02 +00:00 by barrettruth · 0 comments
barrettruth commented 2026-05-09 03:28:02 +00:00
Owner
Copy link

Generalize the current commit-only diff source discovery without enabling risky PR rendering yet.

Scope:

  • Extend URL detection beyond /commit/<sha>.diff to understand PR files pages, PR commit pages, PR commit ranges, compare pages, and raw compare .diff endpoints.
  • Decide when raw /pulls/<index>.diff is acceptable and when server-rendered PR rows must remain the source of truth.
  • Preserve query semantics for style, whitespace, show-outdated, skip-to, and file-only.
  • Keep native fallback when a raw diff does not correspond exactly to the currently displayed PR subset.

Acceptance:

  • A helper can classify the current page as commit diff, compare diff, PR all-files, PR single-commit, PR commit-range, or unsupported.
  • No PR review DOM is replaced by this task.
  • Preload only runs where the source URL is known to match the page.

Depends on: PR diffs 1.

Generalize the current commit-only diff source discovery without enabling risky PR rendering yet. Scope: - Extend URL detection beyond `/commit/<sha>.diff` to understand PR files pages, PR commit pages, PR commit ranges, compare pages, and raw compare `.diff` endpoints. - Decide when raw `/pulls/<index>.diff` is acceptable and when server-rendered PR rows must remain the source of truth. - Preserve query semantics for `style`, `whitespace`, `show-outdated`, `skip-to`, and `file-only`. - Keep native fallback when a raw diff does not correspond exactly to the currently displayed PR subset. Acceptance: - A helper can classify the current page as commit diff, compare diff, PR all-files, PR single-commit, PR commit-range, or unsupported. - No PR review DOM is replaced by this task. - Preload only runs where the source URL is known to match the page. Depends on: PR diffs 1.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
No results found.
Labels
Clear labels   
bug
Something isn't working

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
question
Further information is requested

  
wontfix
This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Blocks
#23 Forgejo PR diffs: native Pierre bridge
barrettruth/nix
#27 PR diffs 4: prototype read-only Pierre rendering where safe
barrettruth/nix
Depends on
#24 PR diffs 1: lock down native review DOM contract
barrettruth/nix
Reference
barrettruth/nix#26
No description provided.