PR diffs 2: add fixtures and measurements for review pages #25

Closed
opened 2026-05-09 03:28:02 +00:00 by barrettruth · 0 comments
Owner

Create repeatable verification for PR diff behavior before replacing visuals.

Scope:

  • Identify or create stable local/live PR pages that cover comments, pending review comments, viewed files, folded files, load-more, split/unified, whitespace changes, and outdated comments.
  • Add a lightweight Playwright/manual checklist for the custom Forgejo frontend if automated auth is too much for the first pass.
  • Add performance marks for initial native render, custom repaint start, first custom paint, and final custom paint.

Acceptance:

  • There is a known test matrix with URLs or fixture steps.
  • It catches regressions in adding a line comment, replying to an existing conversation, toggling viewed files, and loading more files.
  • It records cold and warm timings for at least one small PR and one large PR.

Dependency position: root task, can run in parallel with the DOM contract audit.

Create repeatable verification for PR diff behavior before replacing visuals. Scope: - Identify or create stable local/live PR pages that cover comments, pending review comments, viewed files, folded files, load-more, split/unified, whitespace changes, and outdated comments. - Add a lightweight Playwright/manual checklist for the custom Forgejo frontend if automated auth is too much for the first pass. - Add performance marks for initial native render, custom repaint start, first custom paint, and final custom paint. Acceptance: - There is a known test matrix with URLs or fixture steps. - It catches regressions in adding a line comment, replying to an existing conversation, toggling viewed files, and loading more files. - It records cold and warm timings for at least one small PR and one large PR. Dependency position: root task, can run in parallel with the DOM contract audit.
Sign in to join this conversation.
No description provided.