fix: quote LuaRocks command arguments #4

Merged

barrettruth merged 3 commits from harden/shell-command-args into main 2026-05-04 02:13:23 +00:00

Conversation 0 Commits 3 Files changed 9 +145 -37

barrettruth commented 2026-05-04 01:56:01 +00:00

Owner

Copy link

Problem
The publisher builds LuaRocks and shell commands by concatenating dynamic inputs. That is too fragile for a reusable public action because repository names, paths, verification servers, and extra LuaRocks args should be treated as argv values instead of shell text.

Solution
Add central shell argument quoting helpers, build LuaRocks commands from argv-style lists, keep LUAROCKS_API_KEY expanded from the environment without printing its value, use temporary files for command capture, and document the newline-separated extra_luarocks_args contract.

Verification

• nix develop --accept-flake-config .#ci --command just ci

Problem The publisher builds LuaRocks and shell commands by concatenating dynamic inputs. That is too fragile for a reusable public action because repository names, paths, verification servers, and extra LuaRocks args should be treated as argv values instead of shell text. Solution Add central shell argument quoting helpers, build LuaRocks commands from argv-style lists, keep LUAROCKS_API_KEY expanded from the environment without printing its value, use temporary files for command capture, and document the newline-separated extra_luarocks_args contract. Verification - nix develop --accept-flake-config .#ci --command just ci

barrettruth added 1 commit 2026-05-04 01:56:01 +00:00

fix: quote LuaRocks command arguments b0f529a00e

barrettruth changed target branch from fix/api-key-only-for-upload to main 2026-05-04 01:57:41 +00:00

barrettruth force-pushed harden/shell-command-args from b0f529a00e to 07ae4c4e19 2026-05-04 01:58:09 +00:00 Compare

barrettruth force-pushed harden/shell-command-args from 07ae4c4e19 to 5014cb887f 2026-05-04 01:59:34 +00:00 Compare

barrettruth merged commit cf9cefe782 into main 2026-05-04 02:13:23 +00:00

barrettruth deleted branch harden/shell-command-args 2026-05-04 02:13:23 +00:00

barrettruth referenced this pull request from a commit 2026-05-04 02:13:25 +00:00

fix: quote LuaRocks command arguments (#4)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

barrettruth/luarocks-tag-release-forgejo!4

No description provided.