barrettruth/luarocks-tag-release-forgejo
1
0
Fork 0
Code Issues Pull requests Releases Packages Activity Actions

fix: require LuaRocks token only for uploads #3

Merged
barrettruth merged 2 commits from fix/api-key-only-for-upload into main 2026-05-04 02:13:14 +00:00
Conversation 0 Commits 2 Files changed 4 +40 -5
barrettruth commented 2026-05-04 01:54:15 +00:00
Owner
Copy link

Problem
The action currently requires LUAROCKS_API_KEY before it knows whether the run will upload. Pull-request dry runs should validate rockspec generation and install behavior without requiring publish secrets.

Solution
Detect pull-request runs before reading upload-only secrets, require LUAROCKS_API_KEY only for upload runs, and add entrypoint coverage for both upload and PR modes.

Verification

  • nix develop --accept-flake-config .#ci --command just ci
Problem The action currently requires LUAROCKS_API_KEY before it knows whether the run will upload. Pull-request dry runs should validate rockspec generation and install behavior without requiring publish secrets. Solution Detect pull-request runs before reading upload-only secrets, require LUAROCKS_API_KEY only for upload runs, and add entrypoint coverage for both upload and PR modes. Verification - nix develop --accept-flake-config .#ci --command just ci
barrettruth changed target branch from ci/aarch64-build-check to main 2026-05-04 01:57:40 +00:00
barrettruth force-pushed fix/api-key-only-for-upload from c68f1a4efb to d450415175
Some checks failed
quality / Test (pull_request) Failing after 5s
Details
quality / Lint (pull_request) Successful in 6s
Details
quality / Format (pull_request) Successful in 7s
Details
quality / Build aarch64 (pull_request) Successful in 6s
Details
2026-05-04 01:58:09 +00:00 Compare
barrettruth force-pushed fix/api-key-only-for-upload from d450415175
Some checks failed
quality / Test (pull_request) Failing after 5s
Details
quality / Lint (pull_request) Successful in 6s
Details
quality / Format (pull_request) Successful in 7s
Details
quality / Build aarch64 (pull_request) Successful in 6s
Details
to cf70e95db5
All checks were successful
quality / Lint (pull_request) Successful in 5s
Details
quality / Format (pull_request) Successful in 7s
Details
quality / Build aarch64 (pull_request) Successful in 6s
Details
quality / Test (pull_request) Successful in 12s
Details
2026-05-04 01:59:34 +00:00 Compare
barrettruth deleted branch fix/api-key-only-for-upload 2026-05-04 02:13:17 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
barrettruth/luarocks-tag-release-forgejo!3
No description provided.