Report backend browse failures #655

Merged
barrettruth merged 1 commit from fix/642-backend-browse-failures into main 2026-05-06 22:32:47 +00:00
Owner

Summary

  • Adds callbacks to GitHub/GitLab CLI-backed browser launches and reports failures with context.
  • Makes GitLab/Forgejo subject probes treat auth/network failures as command failures while preserving true not-found warnings.
  • Routes backend browser-open failures through contextual messages.

Reproduction

Before coding, I loaded this checkout with system nvim via vim.pack + lz.n and stubbed failing backend commands.

  • Before: GitHub browser launch failures had no callback and logged nothing; GitLab subject probes warned no MR or issue found for #42.
  • After: the same packed repro reports contextual failures without command text or stream labels. The runtime message keeps the request id on a separate unlabeled line; the table folds it into parentheses for readability.
Before After
No message was reported. failed to open GitHub PR #42 in browser: authentication failed (request id abc123)
no MR or issue found for #42 failed to resolve GitLab subject #42: authentication failed (request id abc123)

Verification

  • just test spec/sources_spec.lua
  • just test
  • nix develop .#ci --command just ci

Closes #642

## Summary - Adds callbacks to GitHub/GitLab CLI-backed browser launches and reports failures with context. - Makes GitLab/Forgejo subject probes treat auth/network failures as command failures while preserving true not-found warnings. - Routes backend browser-open failures through contextual messages. ## Reproduction Before coding, I loaded this checkout with system nvim via vim.pack + lz.n and stubbed failing backend commands. - Before: GitHub browser launch failures had no callback and logged nothing; GitLab subject probes warned no MR or issue found for #42. - After: the same packed repro reports contextual failures without command text or stream labels. The runtime message keeps the request id on a separate unlabeled line; the table folds it into parentheses for readability. | Before | After | | --- | --- | | No message was reported. | failed to open GitHub PR #42 in browser: authentication failed (request id abc123) | | no MR or issue found for #42 | failed to resolve GitLab subject #42: authentication failed (request id abc123) | ## Verification - `just test spec/sources_spec.lua` - `just test` - `nix develop .#ci --command just ci` Closes #642
Report backend browse failures
All checks were successful
quality / Format (pull_request) Successful in 22s
quality / Lint (pull_request) Successful in 24s
quality / Test (pull_request) Successful in 26s
af7dd66c1e
barrettruth deleted branch fix/642-backend-browse-failures 2026-05-06 22:32:47 +00:00
Sign in to join this conversation.
No description provided.