Detect forge source from parsed remote host #662

New issue

Closed

opened 2026-05-09 00:46:38 +00:00 by barrettruth · 0 comments

barrettruth commented

2026-05-09 00:46:38 +00:00

Owner

Problem

Forge detection parses the remote host but then matches configured host aliases against the full remote URL:

host parsing: lua/forge/detect.lua:52
full-URL matching: lua/forge/detect.lua:124

With broad defaults like github, gitlab, and forgejo, a username or repo path containing another forge name can select the wrong backend.

Expected

Match source host patterns against the parsed remote host, not arbitrary substrings in the full remote URL. Preserve configured host override behavior for actual hosts.

Non-goals

Do not add support for new forge APIs or change the configured source shape.

Context

Found during release-preview readiness audit. Remote Forgejo CI cannot currently be awaited because the Spark runner is down; use local verification for the fix.

## Problem Forge detection parses the remote host but then matches configured host aliases against the full remote URL: - host parsing: `lua/forge/detect.lua:52` - full-URL matching: `lua/forge/detect.lua:124` With broad defaults like `github`, `gitlab`, and `forgejo`, a username or repo path containing another forge name can select the wrong backend. ## Expected Match source host patterns against the parsed remote host, not arbitrary substrings in the full remote URL. Preserve configured host override behavior for actual hosts. ## Non-goals Do not add support for new forge APIs or change the configured source shape. ## Context Found during release-preview readiness audit. Remote Forgejo CI cannot currently be awaited because the Spark runner is down; use local verification for the fix.

barrettruth added the

bug

label

2026-05-09 00:46:38 +00:00

barrettruth referenced this issue

2026-05-09 00:47:16 +00:00

Tracker: release-preview readiness follow-up #667

barrettruth referenced this issue from a pull request that will close it,

2026-05-09 00:54:39 +00:00

fix: detect forge from parsed remote host #670

barrettruth closed this issue

2026-05-09 02:39:06 +00:00