barrettruth/delta
1
0
Fork 0
Code Issues 6 Pull requests 1 Releases 3 Packages Activity Actions

refactor: split keymap definitions by domain #394

Merged
barrettruth merged 1 commit from issue-387-split-keymap-defs into main 2026-05-12 13:45:02 +00:00
Conversation 0 Commits 1 Files changed 12 +919 -720
barrettruth commented 2026-05-12 13:33:02 +00:00
Owner
Copy link

Problem

src/lib/keymap-defs.ts owned every shortcut declaration, help row, scope fallback, and runtime lookup helper, making behavior-preserving keymap changes hard to review.

Solution

  • Split declarations into src/lib/keymap/ modules for global, queue, kanban, calendar, navigation, task detail, sections, and help rows.
  • Keep @/lib/keymap-defs as the compatibility aggregate exporting the same public contracts and matching helpers.
  • Preserve existing key ids, order, help copy, section fallback, modifier matching, and calendar/task-panel/navigation bindings.

Verification

  • nix develop --command pnpm vitest run tests/lib/keymap-defs.test.ts
  • nix develop --command pnpm biome check src/lib/keymap-defs.ts src/lib/keymap tests/lib/keymap-defs.test.ts
  • nix develop --command just ci

Closes #387

## Problem `src/lib/keymap-defs.ts` owned every shortcut declaration, help row, scope fallback, and runtime lookup helper, making behavior-preserving keymap changes hard to review. ## Solution - Split declarations into `src/lib/keymap/` modules for global, queue, kanban, calendar, navigation, task detail, sections, and help rows. - Keep `@/lib/keymap-defs` as the compatibility aggregate exporting the same public contracts and matching helpers. - Preserve existing key ids, order, help copy, section fallback, modifier matching, and calendar/task-panel/navigation bindings. ## Verification - `nix develop --command pnpm vitest run tests/lib/keymap-defs.test.ts` - `nix develop --command pnpm biome check src/lib/keymap-defs.ts src/lib/keymap tests/lib/keymap-defs.test.ts` - `nix develop --command just ci` Closes #387
refactor: split keymap definitions by domain
All checks were successful
quality / Test (pull_request) Successful in 17s
Details
quality / Lint (pull_request) Successful in 21s
Details
quality / Build (pull_request) Successful in 43s
Details
44055555e6
barrettruth deleted branch issue-387-split-keymap-defs 2026-05-12 13:45:03 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug
Something isn't working

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
question
Further information is requested

  
status:blocked
Blocked on a decision, credential, or external dependency

  
track:api
API layer track

  
track:auto
Automation track

  
track:core
Core engine track

  
track:deploy
Deployment track

  
track:infra
Infrastructure track

  
track:ui
Web UI track

  
type:cleanup
Small cleanup, polish, or consolidation work

  
type:docs
Documentation and operator guidance

  
type:epic
Umbrella issue that coordinates related work

  
type:release
Release, packaging, and versioning work

  
type:research
Decision or investigation work before implementation

  
wontfix
This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
status:blocked
track:api
track:auto
track:core
track:deploy
track:infra
track:ui
type:cleanup
type:docs
type:epic
type:release
type:research
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
barrettruth/delta!394
No description provided.