refactor: normalize keyboard scope handling #382

Merged

barrettruth merged 1 commit from issue-324-keyboard-scope-normalize into main

2026-05-12 12:54:27 +00:00

barrettruth commented

2026-05-12 12:45:24 +00:00

Owner

Problem

Keyboard guard behavior was duplicated across global navigation, queue, kanban, calendar, settings, popovers, dialogs, and task detail handlers.

Solution

Add a shared keyboard scope helper for editable focus detection, browser shortcut guards, modifier-only keys, scoped handler checks, and keydown registration.
Migrate representative global, view, settings, dialog, popover, and task-panel handlers to the shared contract.
Keep fixed shortcut definitions and help text intact while removing leftover customization metadata.
Add helper contract coverage and a representative scoped keydown registration test.

Verification

nix develop --command sh -c "pnpm install --frozen-lockfile && pnpm vitest run tests/lib/keyboard.test.ts tests/lib/keymap-defs.test.ts --reporter=verbose"
nix develop --command just lint
nix develop --command just test
nix develop --command just build

Closes #324

## Problem Keyboard guard behavior was duplicated across global navigation, queue, kanban, calendar, settings, popovers, dialogs, and task detail handlers. ## Solution - Add a shared keyboard scope helper for editable focus detection, browser shortcut guards, modifier-only keys, scoped handler checks, and keydown registration. - Migrate representative global, view, settings, dialog, popover, and task-panel handlers to the shared contract. - Keep fixed shortcut definitions and help text intact while removing leftover customization metadata. - Add helper contract coverage and a representative scoped keydown registration test. ## Verification - nix develop --command sh -c "pnpm install --frozen-lockfile && pnpm vitest run tests/lib/keyboard.test.ts tests/lib/keymap-defs.test.ts --reporter=verbose" - nix develop --command just lint - nix develop --command just test - nix develop --command just build Closes #324

barrettruth added 1 commit

2026-05-12 12:45:24 +00:00

refactor keyboard scope handling

quality / Test (pull_request) Successful in 17s

Details

quality / Lint (pull_request) Successful in 21s

Details

quality / Build (pull_request) Successful in 42s

Details

fc6c2df293