cleanup: canonicalize external link provider IDs #373

Merged

barrettruth merged 1 commit from issue-358-canonical-external-link-provider-ids into main 2026-05-12 12:42:03 +00:00

Conversation 0 Commits 1 Files changed 8 +132 -18

barrettruth commented 2026-05-11 21:10:37 +00:00

Owner

Copy link

Problem

• task_external_links provider IDs were repeated as raw strings across core helpers, iCal import, and schema tests.

Solution

• add a canonical external-link provider contract for ical, google_calendar, and google_tasks.
• type external-link helpers and the schema provider column against that contract.
• use the canonical IDs in iCal import and provider/schema tests.
• remove the unused ConflictResolution placeholder type.

Verification

• nix develop --command pnpm vitest run tests/core/external-links.test.ts tests/core/ical/import.test.ts tests/core/schema.test.ts --reporter=verbose
• nix develop --command pnpm tsc --noEmit
• nix develop --command just ci

Part of #355
Closes #358

Problem - task_external_links provider IDs were repeated as raw strings across core helpers, iCal import, and schema tests. Solution - add a canonical external-link provider contract for ical, google_calendar, and google_tasks. - type external-link helpers and the schema provider column against that contract. - use the canonical IDs in iCal import and provider/schema tests. - remove the unused ConflictResolution placeholder type. Verification - nix develop --command pnpm vitest run tests/core/external-links.test.ts tests/core/ical/import.test.ts tests/core/schema.test.ts --reporter=verbose - nix develop --command pnpm tsc --noEmit - nix develop --command just ci Part of #355 Closes #358

barrettruth added 1 commit 2026-05-11 21:10:37 +00:00

cleanup: canonicalize external link providers d9754b548e

barrettruth force-pushed issue-358-canonical-external-link-provider-ids from d9754b548e to ceca69d042 2026-05-11 21:31:27 +00:00 Compare

barrettruth merged commit c6d4015404 into main 2026-05-12 12:42:03 +00:00

barrettruth deleted branch issue-358-canonical-external-link-provider-ids 2026-05-12 12:42:03 +00:00

barrettruth referenced this pull request from a commit 2026-05-12 12:42:03 +00:00

cleanup: canonicalize external link provider IDs (#373)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

bug

Something isn't working

  

documentation

Improvements or additions to documentation

  

duplicate

This issue or pull request already exists

  

enhancement

New feature or request

  

good first issue

Good for newcomers

  

help wanted

Extra attention is needed

  

invalid

This doesn't seem right

  

question

Further information is requested

  

status:blocked

Blocked on a decision, credential, or external dependency

  

track:api

API layer track

  

track:auto

Automation track

  

track:core

Core engine track

  

track:deploy

Deployment track

  

track:infra

Infrastructure track

  

track:ui

Web UI track

  

type:cleanup

Small cleanup, polish, or consolidation work

  

type:docs

Documentation and operator guidance

  

type:epic

Umbrella issue that coordinates related work

  

type:release

Release, packaging, and versioning work

  

type:research

Decision or investigation work before implementation

  

wontfix

This will not be worked on

No labels

bug

documentation

duplicate

enhancement

good first issue

help wanted

invalid

question

status:blocked

track:api

track:auto

track:core

track:deploy

track:infra

track:ui

type:cleanup

type:docs

type:epic

type:release

type:research

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

barrettruth/delta!373

No description provided.