refactor: collapse provider registry facades #372

Merged

barrettruth merged 1 commit from issue-356-provider-registry into main

2026-05-11 21:23:16 +00:00

barrettruth commented

2026-05-11 21:09:26 +00:00

Owner

Problem

Provider definitions still flowed through thin lib facades, including core imports back through lib.

Solution

Point app, core, and tests at src/core/provider-registry.ts for provider types/helpers.
Use registry provider definitions directly when resolving geocoding priority.
Remove the geocoding and NLP facade files after clearing call sites.

Verification

nix develop --command pnpm vitest run tests/core/provider-registry.test.ts tests/core/geocoding.test.ts tests/core/nlp-config.test.ts tests/core/nlp-recurrence.test.ts tests/api/geocode.test.ts tests/api/nlp-parse-recurrence.test.ts tests/api/settings-nlp.test.ts tests/api/integrations-test-route.test.ts
nix develop --command just ci

Closes #356

Problem - Provider definitions still flowed through thin lib facades, including core imports back through lib. Solution - Point app, core, and tests at src/core/provider-registry.ts for provider types/helpers. - Use registry provider definitions directly when resolving geocoding priority. - Remove the geocoding and NLP facade files after clearing call sites. Verification - nix develop --command pnpm vitest run tests/core/provider-registry.test.ts tests/core/geocoding.test.ts tests/core/nlp-config.test.ts tests/core/nlp-recurrence.test.ts tests/api/geocode.test.ts tests/api/nlp-parse-recurrence.test.ts tests/api/settings-nlp.test.ts tests/api/integrations-test-route.test.ts - nix develop --command just ci Closes #356

barrettruth added 1 commit

2026-05-11 21:09:26 +00:00

refactor: collapse provider registry facades

quality / Test (pull_request) Successful in 16s

Details

quality / Lint (pull_request) Successful in 21s

Details

quality / Build (pull_request) Successful in 42s

Details

5ef12aa4c3