cleanup: remove integrations settings route #371

Merged
barrettruth merged 1 commit from issue-313-remove-integrations-settings-route into main 2026-05-11 21:23:11 +00:00
Owner

Problem

The settings integrations page is a placeholder that points users back to calendar settings, so settings still advertises an empty surface.

Solution

  • Remove the direct and intercepted /settings/integrations pages.
  • Remove IntegrationsSection and its placeholder test.
  • Remove the integrations nav section and update settings navigation/keymap tests for the remaining account, calendar, and preferences order.
  • Keep /api/settings/integrations* routes and the calendar provider settings flow intact.

Verification

  • nix develop --command sh -c 'pnpm install --frozen-lockfile && pnpm vitest run tests/lib/settings-navigation.test.ts tests/lib/keymap-defs.test.ts tests/lib/settings-primitives.test.ts tests/lib/calendar-settings-section.test.ts tests/api/settings-integrations.test.ts tests/api/integrations-test-route.test.ts --reporter=verbose'
  • nix develop --command just lint
  • nix develop --command just test
  • nix develop --command just build

Closes #313

## Problem The settings integrations page is a placeholder that points users back to calendar settings, so settings still advertises an empty surface. ## Solution - Remove the direct and intercepted `/settings/integrations` pages. - Remove `IntegrationsSection` and its placeholder test. - Remove the integrations nav section and update settings navigation/keymap tests for the remaining account, calendar, and preferences order. - Keep `/api/settings/integrations*` routes and the calendar provider settings flow intact. ## Verification - `nix develop --command sh -c 'pnpm install --frozen-lockfile && pnpm vitest run tests/lib/settings-navigation.test.ts tests/lib/keymap-defs.test.ts tests/lib/settings-primitives.test.ts tests/lib/calendar-settings-section.test.ts tests/api/settings-integrations.test.ts tests/api/integrations-test-route.test.ts --reporter=verbose'` - `nix develop --command just lint` - `nix develop --command just test` - `nix develop --command just build` Closes #313
cleanup: remove integrations settings route
All checks were successful
quality / Test (pull_request) Successful in 16s
quality / Lint (pull_request) Successful in 21s
quality / Build (pull_request) Successful in 43s
8f85e9df72
barrettruth deleted branch issue-313-remove-integrations-settings-route 2026-05-11 21:23:11 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
barrettruth/delta!371
No description provided.