refactor: split task panel controller #353

Merged

barrettruth merged 1 commit from issue-323-task-panel-refactor into main 2026-05-11 20:50:43 +00:00

Conversation 0 Commits 1 Files changed 7 +1098 -710

barrettruth commented 2026-05-11 20:23:30 +00:00

Owner

Copy link

Problem

src/components/task-panel.tsx mixed form state, autosave sequencing, submit/discard behavior, suggestion derivation, recurrence parsing, and field rendering in one component. That made behavior-preserving task-panel edits hard to review.

This PR now targets current main after #350 and #351. The extracted location field preserves the centralized geocoding provider behavior and visible lookup-failure suggestions from #350.

Solution

• Extract task panel form state, derived suggestion lists, recurrence display/parsing, geocoding lookup errors, and notes tracking into useTaskPanelForm.
• Extract save queue, autosave, create, close/discard, and initial snapshot handling into useTaskPanelPersistence.
• Move panel chrome, metadata fields, location/category suggestion rendering, and notes rendering into focused task-panel components.
• Keep the existing compact classes, keyboard shortcuts, due-date dirty checks, autosave queue semantics, NLP recurrence parsing, and recurrence delete flow intact.

Verification

• nix develop --command pnpm vitest run tests/lib/task-panel-save.test.ts --reporter=verbose
• nix develop --command just lint
• nix develop --command just test
• nix develop --command just build

Closes #323

## Problem `src/components/task-panel.tsx` mixed form state, autosave sequencing, submit/discard behavior, suggestion derivation, recurrence parsing, and field rendering in one component. That made behavior-preserving task-panel edits hard to review. This PR now targets current `main` after #350 and #351. The extracted location field preserves the centralized geocoding provider behavior and visible lookup-failure suggestions from #350. ## Solution - Extract task panel form state, derived suggestion lists, recurrence display/parsing, geocoding lookup errors, and notes tracking into `useTaskPanelForm`. - Extract save queue, autosave, create, close/discard, and initial snapshot handling into `useTaskPanelPersistence`. - Move panel chrome, metadata fields, location/category suggestion rendering, and notes rendering into focused task-panel components. - Keep the existing compact classes, keyboard shortcuts, due-date dirty checks, autosave queue semantics, NLP recurrence parsing, and recurrence delete flow intact. ## Verification - `nix develop --command pnpm vitest run tests/lib/task-panel-save.test.ts --reporter=verbose` - `nix develop --command just lint` - `nix develop --command just test` - `nix develop --command just build` Closes #323

barrettruth added 1 commit 2026-05-11 20:23:30 +00:00

refactor: split task panel controller 64074a4c9a

barrettruth force-pushed issue-323-task-panel-refactor from 64074a4c9a to 0a020d4d31 2026-05-11 20:27:05 +00:00 Compare

barrettruth changed target branch from main to cleanup/geocoding-provider-config-315-v2 2026-05-11 20:27:13 +00:00

barrettruth changed target branch from cleanup/geocoding-provider-config-315-v2 to main 2026-05-11 20:29:39 +00:00

barrettruth force-pushed issue-323-task-panel-refactor from 0a020d4d31 to 38df15a503 2026-05-11 20:35:33 +00:00 Compare

barrettruth force-pushed issue-323-task-panel-refactor from 0a020d4d31 to 38df15a503 2026-05-11 20:36:00 +00:00 Compare

barrettruth merged commit e5489b457c into main 2026-05-11 20:50:43 +00:00

barrettruth deleted branch issue-323-task-panel-refactor 2026-05-11 20:50:43 +00:00

barrettruth referenced this pull request from a commit 2026-05-11 20:50:44 +00:00

refactor: split task panel controller (#353)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

bug

Something isn't working

  

documentation

Improvements or additions to documentation

  

duplicate

This issue or pull request already exists

  

enhancement

New feature or request

  

good first issue

Good for newcomers

  

help wanted

Extra attention is needed

  

invalid

This doesn't seem right

  

question

Further information is requested

  

status:blocked

Blocked on a decision, credential, or external dependency

  

track:api

API layer track

  

track:auto

Automation track

  

track:core

Core engine track

  

track:deploy

Deployment track

  

track:infra

Infrastructure track

  

track:ui

Web UI track

  

type:cleanup

Small cleanup, polish, or consolidation work

  

type:docs

Documentation and operator guidance

  

type:epic

Umbrella issue that coordinates related work

  

type:release

Release, packaging, and versioning work

  

type:research

Decision or investigation work before implementation

  

wontfix

This will not be worked on

No labels

bug

documentation

duplicate

enhancement

good first issue

help wanted

invalid

question

status:blocked

track:api

track:auto

track:core

track:deploy

track:infra

track:ui

type:cleanup

type:docs

type:epic

type:release

type:research

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

barrettruth/delta!353

No description provided.