refactor: centralize settings provider registry #352

Merged

barrettruth merged 1 commit from issue-325-provider-registry into main 2026-05-11 20:50:38 +00:00

Conversation 0 Commits 1 Files changed 13 +662 -212

barrettruth commented 2026-05-11 20:22:45 +00:00

Owner

Copy link

Stack

#350 / #315 has merged into main. This PR was rebased onto current origin/main after that merge, so the geocoding provider cleanup is now in the base.

Problem

Provider IDs, labels, token metadata field names, default models, scopes, and provider test routing were duplicated across settings UI and API routes.

Solution

• Add a shared provider registry for settings-owned NLP recurrence and geocoding providers.
• Layer the registry on top of #350's geocoding provider cleanup without re-expanding route-specific geocoding logic.
• Preserve Photon, Mapbox, Google Maps, Anthropic, OpenAI, built-in NLP, current fallback behavior, and current-only token metadata handling.
• Add focused tests for registry definitions, geocoding fallback, integration provider validation, and provider test dispatch.

Verification

• nix develop --command just lint
• nix develop --command just test
• nix develop --command just build

Closes #325

## Stack #350 / #315 has merged into `main`. This PR was rebased onto current `origin/main` after that merge, so the geocoding provider cleanup is now in the base. ## Problem Provider IDs, labels, token metadata field names, default models, scopes, and provider test routing were duplicated across settings UI and API routes. ## Solution - Add a shared provider registry for settings-owned NLP recurrence and geocoding providers. - Layer the registry on top of #350's geocoding provider cleanup without re-expanding route-specific geocoding logic. - Preserve Photon, Mapbox, Google Maps, Anthropic, OpenAI, built-in NLP, current fallback behavior, and current-only token metadata handling. - Add focused tests for registry definitions, geocoding fallback, integration provider validation, and provider test dispatch. ## Verification - `nix develop --command just lint` - `nix develop --command just test` - `nix develop --command just build` Closes #325

barrettruth added 1 commit 2026-05-11 20:22:45 +00:00

refactor: centralize settings provider registry 2b1b123277

barrettruth force-pushed issue-325-provider-registry from 2b1b123277 to 97c270c4ce 2026-05-11 20:31:23 +00:00 Compare

barrettruth force-pushed issue-325-provider-registry from 97c270c4ce to 75c8748a50 2026-05-11 20:33:02 +00:00 Compare

barrettruth merged commit 229be8f1e2 into main 2026-05-11 20:50:38 +00:00

barrettruth deleted branch issue-325-provider-registry 2026-05-11 20:50:38 +00:00

barrettruth referenced this pull request from a commit 2026-05-11 20:50:39 +00:00

refactor: centralize settings provider registry (#352)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

bug

Something isn't working

  

documentation

Improvements or additions to documentation

  

duplicate

This issue or pull request already exists

  

enhancement

New feature or request

  

good first issue

Good for newcomers

  

help wanted

Extra attention is needed

  

invalid

This doesn't seem right

  

question

Further information is requested

  

status:blocked

Blocked on a decision, credential, or external dependency

  

track:api

API layer track

  

track:auto

Automation track

  

track:core

Core engine track

  

track:deploy

Deployment track

  

track:infra

Infrastructure track

  

track:ui

Web UI track

  

type:cleanup

Small cleanup, polish, or consolidation work

  

type:docs

Documentation and operator guidance

  

type:epic

Umbrella issue that coordinates related work

  

type:release

Release, packaging, and versioning work

  

type:research

Decision or investigation work before implementation

  

wontfix

This will not be worked on

No labels

bug

documentation

duplicate

enhancement

good first issue

help wanted

invalid

question

status:blocked

track:api

track:auto

track:core

track:deploy

track:infra

track:ui

type:cleanup

type:docs

type:epic

type:release

type:research

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

barrettruth/delta!352

No description provided.