cleanup: remove NLP legacy token alias #346

Merged

barrettruth merged 1 commit from cleanup/remove-nlp-legacy-token-alias into main

2026-05-11 20:10:09 +00:00

barrettruth commented

2026-05-11 20:09:08 +00:00

Owner

Problem

The merged NLP provider settings path kept a runtime compatibility branch for the old apiKey token field. We do not need to tolerate old settings payload shapes unless a real database migration requires it.

Solution

Remove the legacy apiKey token alias from NLP provider token reads.
Keep the current canonical api_key token contract.
Update the NLP config test to assert old payload aliases are ignored.

Verification

nix develop --command pnpm exec vitest run tests/core/nlp-config.test.ts tests/api/settings-nlp.test.ts tests/api/nlp-parse-recurrence.test.ts --reporter=verbose
nix develop --command just lint

Follow-up to #314.

## Problem The merged NLP provider settings path kept a runtime compatibility branch for the old `apiKey` token field. We do not need to tolerate old settings payload shapes unless a real database migration requires it. ## Solution - Remove the legacy `apiKey` token alias from NLP provider token reads. - Keep the current canonical `api_key` token contract. - Update the NLP config test to assert old payload aliases are ignored. ## Verification - `nix develop --command pnpm exec vitest run tests/core/nlp-config.test.ts tests/api/settings-nlp.test.ts tests/api/nlp-parse-recurrence.test.ts --reporter=verbose` - `nix develop --command just lint` Follow-up to #314.

barrettruth added 1 commit

2026-05-11 20:09:08 +00:00

cleanup: remove NLP legacy token alias

quality / Test (pull_request) Successful in 17s

Details

quality / Lint (pull_request) Successful in 21s

Details

quality / Build (pull_request) Successful in 43s

Details

848b91ead8