fix: align NLP provider settings #342

Merged

barrettruth merged 1 commit from fix/nlp-provider-storage-314 into main

2026-05-11 20:04:58 +00:00

barrettruth commented

2026-05-11 20:04:07 +00:00

Owner

Problem

NLP recurrence settings and the parser route disagreed on the stored provider/token contract and model defaults.
Broken or disabled NLP provider rows could still look active in settings.

Solution

Centralize the small NLP provider contract for provider IDs, storage keys, model defaults, and active-provider lookup.
Store new NLP credentials under the parser contract, tolerate legacy rows server-side, and keep deterministic parsing as the fallback when no enabled provider is usable.
Keep the calendar settings UI using the shared provider list.

Verification

nix develop --command pnpm vitest run tests/core/nlp-config.test.ts tests/core/nlp-recurrence.test.ts tests/api/settings-nlp.test.ts tests/api/nlp-parse-recurrence.test.ts --reporter=verbose
nix develop --command just lint
nix develop --command just test

Closes #314

Problem - NLP recurrence settings and the parser route disagreed on the stored provider/token contract and model defaults. - Broken or disabled NLP provider rows could still look active in settings. Solution - Centralize the small NLP provider contract for provider IDs, storage keys, model defaults, and active-provider lookup. - Store new NLP credentials under the parser contract, tolerate legacy rows server-side, and keep deterministic parsing as the fallback when no enabled provider is usable. - Keep the calendar settings UI using the shared provider list. Verification - nix develop --command pnpm vitest run tests/core/nlp-config.test.ts tests/core/nlp-recurrence.test.ts tests/api/settings-nlp.test.ts tests/api/nlp-parse-recurrence.test.ts --reporter=verbose - nix develop --command just lint - nix develop --command just test Closes #314

barrettruth added 1 commit

2026-05-11 20:04:07 +00:00

fix: align NLP provider settings

quality / Test (pull_request) Successful in 17s

Details

quality / Lint (pull_request) Successful in 21s

Details

quality / Build (pull_request) Successful in 46s

Details

66e95dd3ce