fix: restore settings modal background #336

Merged

barrettruth merged 2 commits from fix/settings-overlay-background-306 into main

2026-05-11 19:53:58 +00:00

barrettruth commented

2026-05-11 19:52:06 +00:00

Owner

Problem

Settings routes still used the modal shell after the routing cleanup, but no parallel slot kept the originating dashboard page mounted behind the backdrop.

Solution

Restore the narrow @modal intercepted settings route and re-export the canonical /settings/* pages for modal content.
Render the modal slot from the dashboard layout again.
Make intercepted settings close with history back while direct /settings/* fallback links still close via returnTo.
Add focused coverage for preserving dashboard return targets.

Verification

nix develop --command pnpm vitest run tests/lib/settings-navigation.test.ts --reporter=verbose
nix develop --command just lint
nix develop --command just build

Closes #306

Problem - Settings routes still used the modal shell after the routing cleanup, but no parallel slot kept the originating dashboard page mounted behind the backdrop. Solution - Restore the narrow @modal intercepted settings route and re-export the canonical /settings/* pages for modal content. - Render the modal slot from the dashboard layout again. - Make intercepted settings close with history back while direct /settings/* fallback links still close via returnTo. - Add focused coverage for preserving dashboard return targets. Verification - nix develop --command pnpm vitest run tests/lib/settings-navigation.test.ts --reporter=verbose - nix develop --command just lint - nix develop --command just build Closes #306

barrettruth added 2 commits

2026-05-11 19:52:06 +00:00

cleanup: remove unused system config store

quality / Test (pull_request) Successful in 15s

Details

quality / Lint (pull_request) Successful in 21s

Details

quality / Build (pull_request) Successful in 45s

Details

7dd39c201a