chore: drop three fields nothing reads #24

Merged

barrettruth merged 1 commit from chore/drop-dead-fields into main

2026-07-28 00:03:45 +00:00

barrettruth commented

2026-07-27 23:59:57 +00:00

Owner

Checklist

I have read CONTRIBUTING.md.
No AI was used to generate, edit, or review any part of this contribution.

Problem

Three fields were written and never read.

b:ci.kind was set on every buffer, but the winbar picks its format from the
parsed URI — plugin/ci.lua:63 reads u.kind, not the buffer variable.

b:ci.run_id lost its only reader in #20, when - stopped navigating to the
run.

ci.Check.run_id never had one. The discriminator that yields it,
detailsUrl:match('/actions/runs/(%d+)/job/(%d+)'), only needs the job id
beside it.

Solution

Removed, along with their annotations. Nine lines out, one in.

Worth noting what was not removed: ansi.reset_cache() looked dead by the
same test but is called from spec/ansi_spec.lua to keep the highlight cache
deterministic between cases.

## Checklist - [x] I have read [CONTRIBUTING.md](https://forge.barrettruth.com/barrettruth/ci.nvim/src/branch/main/CONTRIBUTING.md). - [ ] No AI was used to generate, edit, or review any part of this contribution. ## Problem Three fields were written and never read. `b:ci.kind` was set on every buffer, but the winbar picks its format from the parsed URI — `plugin/ci.lua:63` reads `u.kind`, not the buffer variable. `b:ci.run_id` lost its only reader in #20, when `-` stopped navigating to the run. `ci.Check.run_id` never had one. The discriminator that yields it, `detailsUrl:match('/actions/runs/(%d+)/job/(%d+)')`, only needs the job id beside it. ## Solution Removed, along with their annotations. Nine lines out, one in. Worth noting what was *not* removed: `ansi.reset_cache()` looked dead by the same test but is called from `spec/ansi_spec.lua` to keep the highlight cache deterministic between cases.

barrettruth added 1 commit

2026-07-27 23:59:57 +00:00

chore: drop three fields nothing reads

quality / Test (pull_request) Successful in 3s

Details

quality / Format (pull_request) Successful in 12s

Details

quality / Lint (pull_request) Successful in 12s

Details

280308acd7

b:ci.kind was set on every buffer and never looked at; the winbar picks its
format from the parsed URI instead. b:ci.run_id lost its only reader when "-"
stopped navigating to the run, and ci.Check.run_id never had one — the
discriminator that produces it only needs the job id beside it.

barrettruth referenced this pull request

2026-07-28 00:01:06 +00:00

fix: rebuild the timestamp column on reload instead of leaving it stale #25

barrettruth merged commit e444f72b6d into main

2026-07-28 00:03:45 +00:00

barrettruth deleted branch chore/drop-dead-fields

2026-07-28 00:03:45 +00:00

barrettruth referenced this pull request from a commit

2026-07-28 00:03:46 +00:00

chore: drop three fields nothing reads (#24)

barrettruth referenced this pull request

2026-07-28 05:30:47 +00:00