Report vim.ui.open failures in browse actions #665

New issue

Closed

opened 2026-05-09 00:46:57 +00:00 by barrettruth · 0 comments

barrettruth commented

2026-05-09 00:46:57 +00:00

Owner

Problem

Some browse actions ignore vim.ui.open() failures and report success or do nothing visible.

Evidence:

repo browse returns true after vim.ui.open(url): lua/forge/action/ops.lua:776
terminal gx ignores the open result: lua/forge/term.lua:116
checks picker browse ignores the open result: lua/forge/picker/checks.lua:140

This makes browser-provider failures silent in common user actions.

Expected

Handle vim.ui.open() failures consistently, preserving useful failure detail without noisy success-path logging.

Context

Found during release-preview readiness audit. Remote Forgejo CI cannot currently be awaited because the Spark runner is down; use local verification for the fix.

## Problem Some browse actions ignore `vim.ui.open()` failures and report success or do nothing visible. Evidence: - repo browse returns true after `vim.ui.open(url)`: `lua/forge/action/ops.lua:776` - terminal `gx` ignores the open result: `lua/forge/term.lua:116` - checks picker browse ignores the open result: `lua/forge/picker/checks.lua:140` This makes browser-provider failures silent in common user actions. ## Expected Handle `vim.ui.open()` failures consistently, preserving useful failure detail without noisy success-path logging. ## Context Found during release-preview readiness audit. Remote Forgejo CI cannot currently be awaited because the Spark runner is down; use local verification for the fix.

barrettruth added the

bug

label

2026-05-09 00:46:57 +00:00

barrettruth referenced this issue

2026-05-09 00:47:16 +00:00

Tracker: release-preview readiness follow-up #667

barrettruth referenced this issue from a pull request that will close it,

2026-05-09 00:57:21 +00:00

Report vim.ui.open failures in browse actions #672

barrettruth closed this issue

2026-05-09 02:39:13 +00:00