Make repo info, PR state, and current-PR lookups fallible #646

New issue

Closed

opened 2026-05-06 19:56:26 +00:00 by barrettruth · 0 comments

barrettruth commented

2026-05-06 19:56:26 +00:00

Owner

Parent: #634

Problem

Repo info, PR state, and current-PR resolution can parse empty/default data after command failure. Auth, network, or repo-resolution errors may become READ, UNKNOWN, empty merge methods, or no PR found, which then drives availability and action behavior incorrectly.

Scope

Audit backend repo_info, pr_state, and pr_for_branch_cmd paths.
Distinguish real absence from command/API failure.
Preserve failure details for availability and resolution callers without noisy picker behavior.
Add tests for failed lookup commands.

Non-goals

Do not change merge permission semantics.
Do not change branch/head matching rules.
Do not change GitLab project-ID resolution semantics except to report failures.

Parent: #634 ## Problem Repo info, PR state, and current-PR resolution can parse empty/default data after command failure. Auth, network, or repo-resolution errors may become `READ`, `UNKNOWN`, empty merge methods, or `no PR found`, which then drives availability and action behavior incorrectly. ## Scope - Audit backend `repo_info`, `pr_state`, and `pr_for_branch_cmd` paths. - Distinguish real absence from command/API failure. - Preserve failure details for availability and resolution callers without noisy picker behavior. - Add tests for failed lookup commands. ## Non-goals - Do not change merge permission semantics. - Do not change branch/head matching rules. - Do not change GitLab project-ID resolution semantics except to report failures.

barrettruth added the

bug

v0.2.0

labels

2026-05-06 19:56:26 +00:00

barrettruth referenced this issue

2026-05-06 19:56:43 +00:00

Tracker: error handling and edge cases #634

barrettruth referenced this issue from a pull request that will close it,

2026-05-06 23:06:43 +00:00

Make lookup failures fallible #658

barrettruth closed this issue