Guard picker row building after successful JSON decode #644

Closed
opened 2026-05-06 19:55:54 +00:00 by barrettruth · 0 comments
Owner

Parent: #634

Problem

Picker fetch failures and JSON decode failures are now mostly represented as structured failures, but valid JSON with an unexpected shape can still throw after decode during backend normalization, field access, display formatting, or build_entries. Those exceptions can escape async callbacks as scheduled Lua errors instead of becoming picker error rows.

Scope

  • Guard picker row-building after successful JSON decode.
  • Cover PR, issue, CI, checks, and release picker builders.
  • Convert row-builder exceptions into bounded error rows and debug details.
  • Add tests for valid JSON with an unexpected backend shape.

Non-goals

  • Do not change backend schemas.
  • Do not add broad validation beyond the picker boundary.
  • Do not change normal displayed row formats.
Parent: #634 ## Problem Picker fetch failures and JSON decode failures are now mostly represented as structured failures, but valid JSON with an unexpected shape can still throw after decode during backend normalization, field access, display formatting, or `build_entries`. Those exceptions can escape async callbacks as scheduled Lua errors instead of becoming picker error rows. ## Scope - Guard picker row-building after successful JSON decode. - Cover PR, issue, CI, checks, and release picker builders. - Convert row-builder exceptions into bounded error rows and debug details. - Add tests for valid JSON with an unexpected backend shape. ## Non-goals - Do not change backend schemas. - Do not add broad validation beyond the picker boundary. - Do not change normal displayed row formats.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
barrettruth/forge.nvim#644
No description provided.