Standardize picker fetch and decode error rows #638

New issue

Closed

opened 2026-05-06 19:55:42 +00:00 by barrettruth · 0 comments

barrettruth commented

2026-05-06 19:55:42 +00:00

Owner

Parent: #634

Problem

Async picker fetches can fail because the CLI exits nonzero, the network is unavailable, authentication is broken, JSON is invalid, or a backend returns an unexpected shape. Picker error rows and notifications should consistently preserve the actionable part of that failure instead of showing only a generic empty/error row.

Scope

Audit lua/forge/picker/session.lua and picker-specific error_entry call sites.
Use the shared failure formatter from #635 where appropriate.
Ensure PR, issue, CI, release, branch, commit, and source pickers have coherent failure rows.
Add tests for command failure and decode failure rows.

Non-goals

Do not change picker mappings or successful row rendering.
Do not make transient stale requests noisy.

Parent: #634 ## Problem Async picker fetches can fail because the CLI exits nonzero, the network is unavailable, authentication is broken, JSON is invalid, or a backend returns an unexpected shape. Picker error rows and notifications should consistently preserve the actionable part of that failure instead of showing only a generic empty/error row. ## Scope - Audit `lua/forge/picker/session.lua` and picker-specific `error_entry` call sites. - Use the shared failure formatter from #635 where appropriate. - Ensure PR, issue, CI, release, branch, commit, and source pickers have coherent failure rows. - Add tests for command failure and decode failure rows. ## Non-goals - Do not change picker mappings or successful row rendering. - Do not make transient stale requests noisy.

barrettruth added the

bug

v0.2.0

labels

2026-05-06 19:55:42 +00:00

barrettruth referenced this issue

2026-05-06 19:56:06 +00:00

Tracker: error handling and edge cases #634

barrettruth referenced this issue from a pull request that will close it,

2026-05-06 21:31:47 +00:00

Standardize picker failure rows #650

barrettruth closed this issue