Add release picker Ctrl-X open action #609

New issue

Closed

opened 2026-05-06 03:04:03 +00:00 by barrettruth · 1 comment

barrettruth commented

2026-05-06 03:04:03 +00:00

Owner

The release picker is missing the Ctrl-X (<c-x>) browser/open action users expect from other picker surfaces, but this should not be implemented as an isolated binding change yet.

Blocking context:

release currently maps keys.release.browse to <cr>
release has no separate default action
its current browse action is labeled open, sets close = false, opens the browser, and keeps the picker open
#610 must settle the shared picker action contract first: when <cr> closes/relaunches/nests, and when Ctrl-based actions keep the picker open

Likely post-#610 scope:

add or adjust the release picker browser/open action to match the standardized contract
keep Ctrl-X (<c-x>) as the continuity binding if #610 confirms that browser-open is a secondary keep-open action
update docs and tests for release-specific action semantics

Non-goals:

do not solve #610 here
do not change release row rendering here

The release picker is missing the Ctrl-X (`<c-x>`) browser/open action users expect from other picker surfaces, but this should not be implemented as an isolated binding change yet. Blocking context: - release currently maps `keys.release.browse` to `<cr>` - release has no separate `default` action - its current `browse` action is labeled `open`, sets `close = false`, opens the browser, and keeps the picker open - #610 must settle the shared picker action contract first: when `<cr>` closes/relaunches/nests, and when Ctrl-based actions keep the picker open Likely post-#610 scope: - add or adjust the release picker browser/open action to match the standardized contract - keep Ctrl-X (`<c-x>`) as the continuity binding if #610 confirms that browser-open is a secondary keep-open action - update docs and tests for release-specific action semantics Non-goals: - do not solve #610 here - do not change release row rendering here

barrettruth added the

bug

v0.1.0

labels

2026-05-06 03:04:03 +00:00

barrettruth changed title from ~~Add release picker <c-x> open action~~ to Add release picker Ctrl-X open action

2026-05-06 03:04:20 +00:00

~~barrettruth referenced this issue 2026-05-06 03:04:29 +00:00~~

release v0.2.1 follow-up #1

barrettruth referenced this issue

2026-05-06 03:15:21 +00:00

Standardize picker default actions, Ctrl mappings, and close semantics #610

barrettruth commented

2026-05-06 03:15:27 +00:00

Author

Owner

Blocking audit note: this is not a simple missing-binding bug yet.

The release picker currently defines browse as the visible open action, sets close = false, and maps keys.release.browse to <cr>. It does not define a separate default action. As a result, <cr> opens the browser and keeps the picker open, unlike the target default-action philosophy where <cr> should generally close the current picker or replace/nest into another picker.

Do not implement this until #610 settles the picker action contract.

Likely post-#610 shape:

<cr> is the release picker primary/default open action and follows the standardized default close/relaunch semantics.
Ctrl-X (<c-x>) is the secondary browser/open action and keeps the release picker open, matching PR/issue/CI browse behavior.
docs and tests cover the release-specific action contract.

Blocking audit note: this is not a simple missing-binding bug yet. The release picker currently defines `browse` as the visible `open` action, sets `close = false`, and maps `keys.release.browse` to `<cr>`. It does not define a separate `default` action. As a result, `<cr>` opens the browser and keeps the picker open, unlike the target default-action philosophy where `<cr>` should generally close the current picker or replace/nest into another picker. Do not implement this until #610 settles the picker action contract. Likely post-#610 shape: - `<cr>` is the release picker primary/default open action and follows the standardized default close/relaunch semantics. - Ctrl-X (`<c-x>`) is the secondary browser/open action and keeps the release picker open, matching PR/issue/CI browse behavior. - docs and tests cover the release-specific action contract.

barrettruth referenced this issue from a pull request that will close it,

2026-05-06 13:50:59 +00:00

fix: standardize picker action contract #615

barrettruth closed this issue

2026-05-06 13:54:29 +00:00

barrettruth referenced this issue from a commit

2026-05-06 13:54:31 +00:00

fix: standardize picker action contract (#615)