bug: Diff review doesn't skip binary files #177

New issue

Closed

opened 2026-09-21 18:12:59 +00:00 by barrettruth · 3 comments

barrettruth commented

2026-09-21 18:12:59 +00:00

Owner

Original issue: barrettruth/diffs.nvim#416
Original author: SevereOverfl0w
Original date: 2026-07-10T12:56:56Z

Prerequisites

I have searched existing issues
I have updated to the latest version

Neovim version

NVIM v0.13.0-dev-726+ga69f2db773-Homebrew

Operating system

MacOS

Description

Pressing ]f gave me an error message: diff does not support binary files. I would hope to either skip the binary files OR do something sensible (show me "--binary" in a buffer or whatever git does).

In any case, I couldn't skip the binary file to continue my review, not even with 2]f to jump over it or similar.

Steps to reproduce

Modify a text file a and a binary file b and commit it
Diff review ++layout=split HEAD^
]f

Health check

==============================================================================
diffs:                                                                      ✅

diffs.nvim ~
- ✅ OK Neovim 0.9.0+ detected
- ✅ OK vim-fugitive detected
- libvscode_diff not found (optional, using native vim.diff fallback)
- difftastic not enabled (optional, set integrations.difftastic

Minimal reproduction

it did reproduce with this config.

> Original issue: barrettruth/diffs.nvim#416 > Original author: `SevereOverfl0w` > Original date: 2026-07-10T12:56:56Z ### Prerequisites - [x] I have searched [existing issues](https://github.com/barrettruth/diffs.nvim/issues) - [x] I have updated to the latest version ### Neovim version ```text NVIM v0.13.0-dev-726+ga69f2db773-Homebrew ``` ### Operating system MacOS ### Description Pressing `]f` gave me an error message: `diff does not support binary files`. I would hope to either skip the binary files OR do something sensible (show me "--binary" in a buffer or whatever git does). In any case, I couldn't skip the binary file to continue my review, not even with `2]f` to jump over it or similar. ### Steps to reproduce 1. Modify a text file a and a binary file b and commit it 2. `Diff review ++layout=split HEAD^` 3. `]f` ### Health check ```text ============================================================================== diffs: ✅ diffs.nvim ~ - ✅ OK Neovim 0.9.0+ detected - ✅ OK vim-fugitive detected - libvscode_diff not found (optional, using native vim.diff fallback) - difftastic not enabled (optional, set integrations.difftastic ``` ### Minimal reproduction ```lua it did reproduce with this config. ```

barrettruth

2026-09-21 18:12:59 +00:00

closed this issue
added the
bug
label

barrettruth commented

2026-09-21 18:12:59 +00:00

Author

Owner

Original comment: barrettruth/diffs.nvim#416, comment 4936827108
Original author: barrettruth
Original date: 2026-07-10T15:21:57Z

Thanks for taking the time to file a report.

I now log skipped files at an info-level; follow up in this thread if the fix is insufficient!

> Original comment: barrettruth/diffs.nvim#416, comment 4936827108 > Original author: `barrettruth` > Original date: 2026-07-10T15:21:57Z Thanks for taking the time to file a report. I now log skipped files at an info-level; follow up in this thread if the fix is insufficient!

barrettruth commented

2026-09-21 18:12:59 +00:00

Author

Owner

Original comment: barrettruth/diffs.nvim#416, comment 4946151811
Original author: SevereOverfl0w
Original date: 2026-07-11T13:17:02Z

That works a treat, the log doesn't actually show up for me when skipping around with ]f but I do see it in the :messages output. I'd also be OK with it being logged when doing :Diff review ...

> Original comment: barrettruth/diffs.nvim#416, comment 4946151811 > Original author: `SevereOverfl0w` > Original date: 2026-07-11T13:17:02Z That works a treat, the log doesn't actually show up for me when skipping around with `]f` but I do see it in the `:messages` output. I'd also be OK with it being logged when doing `:Diff review ...`

barrettruth commented

2026-09-21 18:12:59 +00:00

Author

Owner

Original comment: barrettruth/diffs.nvim#416, comment 4948087860
Original author: barrettruth
Original date: 2026-07-11T17:40:03Z

duh... see #420 blaze it... just fixed the skipped log "on top" of the current log.

> Original comment: barrettruth/diffs.nvim#416, comment 4948087860 > Original author: `barrettruth` > Original date: 2026-07-11T17:40:03Z duh... see #420 blaze it... just fixed the skipped log "on top" of the current log.