[stacked] Add layout parsing and command completion #155

New issue

Closed

opened 2026-09-21 18:12:35 +00:00 by barrettruth · 0 comments

barrettruth commented

2026-09-21 18:12:35 +00:00

Owner

Original issue: barrettruth/diffs.nvim#361
Original author: barrettruth
Original date: 2026-05-28T02:57:32Z

Part of #358.

Goal

Add the stacked layout value to the command-level layout surface without changing generated rendering yet.

Scope

Introduce a shared layout helper/constants module for unified, stacked, and split if it keeps parser/completion duplication down.
Update :Gdiff parsing to accept ++layout=stacked.
Update :Greview parsing to accept ++layout=stacked.
Update command completion to include ++layout=stacked.
Keep unsupported/repeated layout error handling unchanged.

Non-goals

Do not render single rails in this issue.
Do not change the default layout.
Do not add public config.
Do not change ++layout=split behavior.

Acceptance criteria

gdiff.parse('++layout=stacked ...') returns layout = 'stacked'.
review.parse_command_args('++layout=stacked ...') returns layout = 'stacked'.
:Gdiff and :Greview completion include ++layout=stacked in the agreed order.
Existing unified and split parser/completion behavior remains unchanged.

> Original issue: barrettruth/diffs.nvim#361 > Original author: `barrettruth` > Original date: 2026-05-28T02:57:32Z Part of #358. ## Goal Add the `stacked` layout value to the command-level layout surface without changing generated rendering yet. ## Scope - Introduce a shared layout helper/constants module for `unified`, `stacked`, and `split` if it keeps parser/completion duplication down. - Update `:Gdiff` parsing to accept `++layout=stacked`. - Update `:Greview` parsing to accept `++layout=stacked`. - Update command completion to include `++layout=stacked`. - Keep unsupported/repeated layout error handling unchanged. ## Non-goals - Do not render single rails in this issue. - Do not change the default layout. - Do not add public config. - Do not change `++layout=split` behavior. ## Acceptance criteria - `gdiff.parse('++layout=stacked ...')` returns `layout = 'stacked'`. - `review.parse_command_args('++layout=stacked ...')` returns `layout = 'stacked'`. - `:Gdiff` and `:Greview` completion include `++layout=stacked` in the agreed order. - Existing `unified` and `split` parser/completion behavior remains unchanged.

barrettruth

2026-09-21 18:12:35 +00:00