refactor: extract provider settings primitives #398

Merged

barrettruth merged 1 commit from issue-370-provider-settings-primitives into main

2026-05-12 13:54:03 +00:00

barrettruth commented

2026-05-12 13:52:48 +00:00

Owner

Problem

Calendar settings still duplicated provider row rendering, API-key entry state, and integration key-test requests across the geocoding and NLP sections.

Solution

Add settings-local provider primitives for active provider rows, inline API-key entry, key-entry state, and the shared integration test endpoint call.
Rework geocoding and NLP settings to use those primitives while keeping provider-specific save/delete behavior in CalendarSettingsSection.
Ignore .direnv/ so the local just ci lint target does not follow direnv's Nix shell profile into /nix/store.

Verification

nix develop --command pnpm vitest run tests/lib/provider-settings-primitives.test.tsx tests/lib/calendar-settings-section.test.ts --reporter=verbose
nix develop --command pnpm exec biome check src/components/settings/calendar-settings-section.tsx src/components/settings/provider-settings-primitives.tsx tests/lib/provider-settings-primitives.test.tsx
nix develop --command pnpm typecheck
nix develop --command just ci

Closes #370

## Problem Calendar settings still duplicated provider row rendering, API-key entry state, and integration key-test requests across the geocoding and NLP sections. ## Solution - Add settings-local provider primitives for active provider rows, inline API-key entry, key-entry state, and the shared integration test endpoint call. - Rework geocoding and NLP settings to use those primitives while keeping provider-specific save/delete behavior in `CalendarSettingsSection`. - Ignore `.direnv/` so the local `just ci` lint target does not follow direnv's Nix shell profile into `/nix/store`. ## Verification - `nix develop --command pnpm vitest run tests/lib/provider-settings-primitives.test.tsx tests/lib/calendar-settings-section.test.ts --reporter=verbose` - `nix develop --command pnpm exec biome check src/components/settings/calendar-settings-section.tsx src/components/settings/provider-settings-primitives.tsx tests/lib/provider-settings-primitives.test.tsx` - `nix develop --command pnpm typecheck` - `nix develop --command just ci` Closes #370

barrettruth added 1 commit

2026-05-12 13:52:48 +00:00

refactor: extract provider settings primitives

quality / Test (pull_request) Successful in 16s

Details

quality / Lint (pull_request) Successful in 22s

Details

quality / Build (pull_request) Successful in 43s

Details

c5c458f14c