cleanup: make FullCalendar adapter the canonical calendar contract #390

Closed
opened 2026-05-12 13:17:40 +00:00 by barrettruth · 0 comments
Owner

Problem

src/lib/fullcalendar-adapter.ts and its tests still describe behavior as matching the legacy CalendarView. After the adapter extraction, this should be the canonical calendar rendering contract, not a transitional copy of old component internals.

The wording is not just cosmetic: future calendar refactors should know whether to preserve adapter behavior because it is the contract, not because old component code happened to do it.

Solution

  • Reframe the adapter comments and tests around canonical adapter behavior.
  • Remove "legacy CalendarView" language where the adapter now owns the contract.
  • Add or adjust focused tests only where needed to make the contract explicit.
  • Coordinate with #367 if CalendarView controller extraction changes the adapter call sites.

Non-goals

  • Do not change rendered calendar behavior.
  • Do not rewrite recurrence expansion.
  • Do not add Google Calendar sync behavior here.

Part of #355.

## Problem `src/lib/fullcalendar-adapter.ts` and its tests still describe behavior as matching the legacy `CalendarView`. After the adapter extraction, this should be the canonical calendar rendering contract, not a transitional copy of old component internals. The wording is not just cosmetic: future calendar refactors should know whether to preserve adapter behavior because it is the contract, not because old component code happened to do it. ## Solution - Reframe the adapter comments and tests around canonical adapter behavior. - Remove "legacy CalendarView" language where the adapter now owns the contract. - Add or adjust focused tests only where needed to make the contract explicit. - Coordinate with #367 if CalendarView controller extraction changes the adapter call sites. ## Non-goals - Do not change rendered calendar behavior. - Do not rewrite recurrence expansion. - Do not add Google Calendar sync behavior here. Part of #355.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
barrettruth/delta#390
No description provided.