fix: restore keyboard shortcut discovery #331

Merged

barrettruth merged 3 commits from fix/328-keybinding-discovery into main

2026-05-11 19:43:06 +00:00

barrettruth commented

2026-05-11 19:41:42 +00:00

Owner

Problem

After removing keymap customization, g? still existed in the keymap data but sent users to generic settings. That made built-in shortcuts, including calendar week/month traversal, hard to discover.

Solution

Add a read-only keyboard shortcuts dialog backed by the existing static HELP_SECTIONS.
Route g? and queue/list help paths to the shortcuts dialog instead of generic settings.
Add a visible sidebar shortcuts entry with the g? hint.
Keep settings on S and do not reintroduce editable keymaps.
Clarify the calendar h / l help text as day/week/month traversal.

Product Direction

This chooses the smallest durable surface from the open debate in #328: read-only discoverability, not customization.

Stack

Stacked on #327, which is stacked on #326. Retarget this PR to main after #326 and #327 merge.

Verification

nix develop --command pnpm vitest run tests/lib/fullcalendar-range.test.ts tests/lib/keymap-defs.test.ts tests/lib/app-sidebar.test.ts
nix develop --command pnpm tsc --noEmit
nix develop --command pnpm exec biome check ...
nix develop --command just ci

Closes #328

## Problem After removing keymap customization, `g?` still existed in the keymap data but sent users to generic settings. That made built-in shortcuts, including calendar week/month traversal, hard to discover. ## Solution - Add a read-only keyboard shortcuts dialog backed by the existing static `HELP_SECTIONS`. - Route `g?` and queue/list help paths to the shortcuts dialog instead of generic settings. - Add a visible sidebar `shortcuts` entry with the `g?` hint. - Keep settings on `S` and do not reintroduce editable keymaps. - Clarify the calendar `h / l` help text as day/week/month traversal. ## Product Direction This chooses the smallest durable surface from the open debate in #328: read-only discoverability, not customization. ## Stack Stacked on #327, which is stacked on #326. Retarget this PR to `main` after #326 and #327 merge. ## Verification - `nix develop --command pnpm vitest run tests/lib/fullcalendar-range.test.ts tests/lib/keymap-defs.test.ts tests/lib/app-sidebar.test.ts` - `nix develop --command pnpm tsc --noEmit` - `nix develop --command pnpm exec biome check ...` - `nix develop --command just ci` Closes #328

barrettruth added 1 commit

2026-05-11 19:41:42 +00:00

fix: restore keyboard shortcut discovery ef47c740ca