refactor: clarify dashboard provider ownership #318

Closed
opened 2026-05-11 19:19:51 +00:00 by barrettruth · 0 comments
Owner

Parent: #305

Problem

The app shell providers are currently split across NavigationWrapper, DashboardContent, and feature components. After removing command-bar and keymap customization state, the provider graph should be renamed and simplified so future agents know where shell state lives.

Solution

Create a clear dashboard provider boundary:

  • replace NavigationWrapper with a name that reflects actual ownership, such as DashboardProviders or AppShellProviders
  • make keymaps/navigation/status/undo/task-panel ownership explicit
  • remove any dead command-save-task or command-discard-task event plumbing left after command-bar removal
  • keep behavior unchanged except for deleting dead event paths

Acceptance criteria

  • Provider ownership is obvious from component names and imports.
  • No dead command-bar event listeners remain.
  • Task panel, undo, status bar, sidebar, and keyboard behavior are unchanged.
  • Focused tests or smoke notes cover the shell interactions touched by the PR.
Parent: #305 ## Problem The app shell providers are currently split across `NavigationWrapper`, `DashboardContent`, and feature components. After removing command-bar and keymap customization state, the provider graph should be renamed and simplified so future agents know where shell state lives. ## Solution Create a clear dashboard provider boundary: - replace `NavigationWrapper` with a name that reflects actual ownership, such as `DashboardProviders` or `AppShellProviders` - make keymaps/navigation/status/undo/task-panel ownership explicit - remove any dead `command-save-task` or `command-discard-task` event plumbing left after command-bar removal - keep behavior unchanged except for deleting dead event paths ## Acceptance criteria - Provider ownership is obvious from component names and imports. - No dead command-bar event listeners remain. - Task panel, undo, status bar, sidebar, and keyboard behavior are unchanged. - Focused tests or smoke notes cover the shell interactions touched by the PR.
barrettruth added this to the v0.1.0 milestone 2026-05-11 19:19:51 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
barrettruth/delta#318
No description provided.